Lukewarm take: Editors automatically formatting on save are horrible when collaborating on software.

Because you will inevitably end up with commits containing both meaningful, intended changes and "abide to some styleguide" meaningless changes on whitespace and string delimiters.

And the Reviewer of your PR has to read through all of that and make sense of it. THAT is waste of resources.

@schnittchen counterpoint: your repository should have a defined style and only accept commits that comply with that style. That way, format-on-save becomes really useful

@noiob that requires all existing code to be already in shape, which in my years of experience is extremely rately the case.

Once all linting is done at some point, the problem becomes trivial: all it needs is some check that prevents unlinted code to be committed or integrated, which could be done via CI or git hook.

Follow

@schnittchen nah, you can just format everything in one big commit. It shouldn't even fuck up your history too much

· · Web · 1 · 0 · 0

@noiob if you're only one or two ppl on the team and it's a very small codebase

Sign in to participate in the conversation
Awoo Space

Awoo.space is a Mastodon instance where members can rely on a team of moderators to help resolve conflict, and limits federation with other instances using a specific access list to minimize abuse.

While mature content is allowed here, we strongly believe in being able to choose to engage with content on your own terms, so please make sure to put mature and potentially sensitive content behind the CW feature with enough description that people know what it's about.

Before signing up, please read our community guidelines. While it's a very broad swath of topics it covers, please do your best! We believe that as long as you're putting forth genuine effort to limit harm you might cause – even if you haven't read the document – you'll be okay!